SqlClient public API renaming proposal for db.statement properties

[mbakalov]

Discussion point raised in: #1599, regarding properties that control setting of the db.statement semantic convention.

Current SqlClientInstrumentationOptions public API looks like this:

• netcore
  • SetStoredProcedureCommandName
  • SetTextCommandContent
• netfx
  • SetStatementText (controls both sp and sqltext as there is no way to tell the difference in netfx)

The suggestion is to make this more uniform and rename to:

• netcore

  • SetDbStatementForStoredProcedure
  • SetDbStatementForText

• netfx

  • SetDbStatement

• Changes in public API reviewed

[codecov]

Codecov Report

Merging #1645 (4a7f787) into master (c7e5f07) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         250      250           
  Lines        6748     6748           
=======================================
  Hits         5543     5543           
  Misses       1205     1205           

Impacted Files	Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs	77.94% <100.00%> (ø)
...ation.SqlClient/SqlClientInstrumentationOptions.cs	98.64% <100.00%> (ø)

[cijothomas]

Proposed names look better.
Not explicitly approving, as pr is still marked Draft.

[mbakalov]

@cijothomas - thank you for looking at it! Sorry, I've been away from this for a couple of days, but made a few updates now.