Instrumentation.AwsLambda: Fix versioning scheme. - #639
Merged
utpilla merged 2 commits intoSep 14, 2022
Merged
Conversation
Oberon00
marked this pull request as ready for review
September 14, 2022 11:43
Oberon00
commented
Sep 14, 2022
| * BREAKING (API, behavior): Rename package to `OpenTelemetry.Instrumentation.AWSLambda` | ||
| (remove `.Contrib`) ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). | ||
| This also affects the `ActivitySource` name (superseding [#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)). | ||
| * Pre-release version numbering scheme changed from `.betaN` to `beta.N` ([#639](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/639)) |
Member
Author
There was a problem hiding this comment.
I noticed this does not require a change in the unit tests since we use the Assembly version which has a fixed format of four integers. IMHO this is wrong and we should use the assembly product version instead. But consistency between different packages is at least as important, so this should be discussed in general, not just for this package.
Kielek
approved these changes
Sep 14, 2022
utpilla
reviewed
Sep 14, 2022
| ## 1.1.0-beta2 | ||
| ## 1.1.0-beta.2 | ||
|
|
||
| Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/590) |
Contributor
There was a problem hiding this comment.
nit: We don't need an entry for Release PR.
utpilla
approved these changes
Sep 14, 2022
utpilla
added
the
comp:instrumentation.awslambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #590 (comment), CC @utpilla
Changes
Changes version numbering scheme of the Instrumentation.AwsLambda which was previously released as 1.1.0.beta1 (& different package name) to use a dot before the pre-release number.