Skip to content

[ServiceFabricRemoting] Bump Service Fabric dependencies to 8.4.268 - #4510

Merged
Kielek merged 2 commits into
open-telemetry:mainfrom
sablancoleis:sfr/bump-servicefabric-8.4
Jun 16, 2026
Merged

[ServiceFabricRemoting] Bump Service Fabric dependencies to 8.4.268#4510
Kielek merged 2 commits into
open-telemetry:mainfrom
sablancoleis:sfr/bump-servicefabric-8.4

Conversation

@sablancoleis

Copy link
Copy Markdown
Contributor

Fixes #

Changes

Raises the minimum required version of Microsoft.ServiceFabric.Actors and
Microsoft.ServiceFabric.Services.Remoting from 7.1.2448 to 8.4.268. The
Service Fabric 7.1 runtime is going out of support, so the library should
floor at a supported runtime version.

The library's remoting adapter surface (IServiceRemotingClient,
IServiceRemotingClientFactory, IServiceRemotingMessageDispatcher, etc.) is
unchanged between 7.1 and 8.4 and recompiles cleanly.

Also adds an explicit System.Fabric binding redirect to the test project's
App.config. With the old 7.1 floor, MSBuild auto-generated this redirect to
resolve a version conflict between ServiceFabric.Mocks and the
Microsoft.ServiceFabric.* packages. The 8.4 floor removes that conflict (and
therefore the auto-generated redirect), which exposed a latent
TypeLoadException in the ServiceFabric.Mocks state provider/manager on the
net462 target. Declaring the redirect explicitly makes the tests
deterministic regardless of the resolved package graph. The redirect is ignored
on the net8.0/net9.0/net10.0 targets.

Validated: all four target frameworks (net462, net8.0, net9.0,
net10.0) build clean and pass 6/6 tests.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated (n/a - no behavior change; existing tests pass)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (n/a - no public API change)

Raise the minimum required version of Microsoft.ServiceFabric.Actors and
Microsoft.ServiceFabric.Services.Remoting from 7.1.2448 to 8.4.268, as the
7.1 Service Fabric runtime is going out of support.

Add an explicit System.Fabric binding redirect to the test project's
App.config so the ServiceFabric.Mocks-based state provider/manager tests
type-load correctly on net462. With the 7.1 floor MSBuild auto-generated
this redirect because of a version conflict; the 8.4 floor removes the
conflict (and the redirect), so it must be declared explicitly.
@sablancoleis
sablancoleis requested a review from a team as a code owner June 16, 2026 04:58
@github-actions github-actions Bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting labels Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.91%. Comparing base (6f85636) to head (c3fe0b7).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4510      +/-   ##
==========================================
- Coverage   75.93%   75.91%   -0.03%     
==========================================
  Files         439      439              
  Lines       18050    18050              
==========================================
- Hits        13707    13702       -5     
- Misses       4343     4348       +5     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 89.79% <ø> (ø)
unittests-Exporter.Geneva 55.10% <ø> (-0.33%) ⬇️
unittests-Exporter.InfluxDB 95.75% <ø> (ø)
unittests-Exporter.OneCollector 94.67% <ø> (ø)
unittests-Extensions 90.61% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 85.08% <ø> (ø)
unittests-Instrumentation.AspNet 77.50% <ø> (ø)
unittests-Instrumentation.AspNetCore 87.34% <ø> (ø)
unittests-Instrumentation.Cassandra 92.68% <ø> (ø)
unittests-Instrumentation.ConfluentKafka 82.04% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.36% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 81.02% <ø> (ø)
unittests-Instrumentation.EventCounters 77.47% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.18% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 78.50% <ø> (ø)
unittests-Instrumentation.Hangfire 88.83% <ø> (ø)
unittests-Instrumentation.Http 74.81% <ø> (ø)
unittests-Instrumentation.Owin 88.88% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 78.37% <ø> (ø)
unittests-Instrumentation.Remoting 65.59% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 39.91% <ø> (ø)
unittests-Instrumentation.SqlClient 82.36% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 94.18% <ø> (ø)
unittests-Instrumentation.Wcf 82.23% <ø> (ø)
unittests-OpAmp.Client 86.26% <ø> (+0.69%) ⬆️
unittests-PersistentStorage 69.20% <ø> (+1.46%) ⬆️
unittests-Resources.AWS 73.61% <ø> (ø)
unittests-Resources.Azure 87.67% <ø> (ø)
unittests-Resources.Container 67.34% <ø> (ø)
unittests-Resources.Gcp 71.42% <ø> (ø)
unittests-Resources.Host 72.26% <ø> (ø)
unittests-Resources.OperatingSystem 76.98% <ø> (ø)
unittests-Resources.Process 90.47% <ø> (ø)
unittests-Resources.ProcessRuntime 79.59% <ø> (ø)
unittests-Sampler.AWS 95.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek
Kielek added this pull request to the merge queue Jun 16, 2026
Merged via the queue into open-telemetry:main with commit 91c80ba Jun 16, 2026
313 checks passed
This was referenced Jun 19, 2026
This was referenced Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.servicefabricremoting Things related to OpenTelemetry.Instrumentation.ServiceFabricRemoting dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants