Skip to content

Upgrade AWS Sampler to use the AWS Semantic Conventions - #2538

Closed
ppittle wants to merge 2 commits into
open-telemetry:mainfrom
ppittle:aws-sampler-semconv
Closed

Upgrade AWS Sampler to use the AWS Semantic Conventions#2538
ppittle wants to merge 2 commits into
open-telemetry:mainfrom
ppittle:aws-sampler-semconv

Conversation

@ppittle

@ppittle ppittle commented Feb 1, 2025

Copy link
Copy Markdown
Member

Draft Pending https://cloud-native.slack.com/archives/C01N3BC2W7Q/p1738279011880949

Changes

This incorporates the Semantic Convention strategy done in #2367 and #2437 for OpenTelemetry.Sampler.AWS in clear the way to launch a RC and then Stable version of OpenTelemetry.Sampler.AWS.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions
github-actions Bot requested a review from srprash February 1, 2025 04:47
@github-actions github-actions Bot added the comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS label Feb 1, 2025
@github-actions

github-actions Bot commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Feb 9, 2025
@codecov

codecov Bot commented Feb 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (d33855a).
Report is 734 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2538       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

@github-actions

Copy link
Copy Markdown
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant