[Instrumentation.AWSLambda] Update to net6.0 - #1545
Merged
Kielek merged 8 commits intoJan 22, 2024
Merged
Conversation
Target `net6.0` instead of `netstandard2.0` as AWS Lambda no longer supports versions of .NET less than .NET 6.
martincostello
commented
Jan 22, 2024
Add the right PR number.
1 task
Kielek
added
the
comp:instrumentation.awslambda
Use `not null` instead of `{ }` to address feedback.
Fix syntax so it compiles.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 73.91% 80.58% +6.67%
==========================================
Files 267 113 -154
Lines 9615 3055 -6560
==========================================
- Hits 7107 2462 -4645
+ Misses 2508 593 -1915
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Hard-code the name, rather than use reflection that might fail in native AoT. - Use `[AssemblyFileVersionAttribute]` to get the version for the same reason.
Revert change to syntax to the terser version.
martincostello
commented
Jan 22, 2024
martincostello
marked this pull request as ready for review
January 22, 2024 12:29
Kielek
reviewed
Jan 22, 2024
Use `[AssemblyInformationalVersion]` so pre-release version information is included, but remove the Git SHA.
Oberon00
approved these changes
Jan 22, 2024
rypdal
approved these changes
Jan 22, 2024
cijothomas
approved these changes
Jan 22, 2024
Kielek
approved these changes
Jan 22, 2024
This was referenced Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1523.
Changes
Spun off from #1544.
Target
net6.0instead ofnetstandard2.0as AWS Lambda no longer supports versions of .NET less than .NET 6.CHANGELOG.mdupdated for non-trivial changes