[Instrumentation.AWSLambda] Enable nullable - #1295
Merged
Kielek merged 21 commits intoAug 10, 2023
Merged
Conversation
utpilla
added
the
comp:instrumentation.awslambda
Oberon00
reviewed
Aug 8, 2023
Oberon00
reviewed
Aug 8, 2023
Oberon00
reviewed
Aug 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 74.23% 74.14% -0.10%
==========================================
Files 256 256
Lines 9345 9347 +2
==========================================
- Hits 6937 6930 -7
- Misses 2408 2417 +9
|
Oberon00
reviewed
Aug 8, 2023
Oberon00
left a comment
Oberon00
left a comment
Member
There was a problem hiding this comment.
Please also add a CHANGELOG entry.
…ion/AWSMessagingUtilsTests.cs open-telemetry#894: review suggestion Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
…functions it must be always available)
Oberon00
reviewed
Aug 8, 2023
Oberon00
reviewed
Aug 8, 2023
Oberon00
reviewed
Aug 8, 2023
…ion/AWSMessagingUtilsTests.cs open-telemetry#894: applied suggestion Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Oberon00
reviewed
Aug 9, 2023
Oberon00
reviewed
Aug 9, 2023
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Kielek
reviewed
Aug 9, 2023
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Oberon00
reviewed
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #894
Changes
Enabled Nullable for OpenTelemetry.Instrumentation.AWSLambda projects and it's tests. Code has been adapted accordingly.