Assign correct value to ext_dt_spanId in Tld Geneva exporter - #1184
Merged
Conversation
|
|
github-actions
Bot
requested review from
CodeBlanch,
Yun-Ting,
cijothomas,
reyang and
utpilla
May 11, 2023 10:37
manio143
force-pushed
the
geneva-tld-spanid-fix
branch
from
May 11, 2023 10:39
25712cb to
bf49696
Compare
Kielek
added
the
comp:exporter.geneva
Contributor
Author
Done 👍 |
reyang
approved these changes
May 11, 2023
reyang
left a comment
reyang
left a comment
Member
There was a problem hiding this comment.
LGTM with an entry in CHANGELOG.md.
utpilla
approved these changes
May 11, 2023
Contributor
Author
Do you want me to make another change as part of this PR? |
Member
Yes please, to add changelog entry! |
cijothomas
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I was testing the Geneva TldExporter locally (it produces very nice info into the EventSource) and I noticed the spanId value was too long and the same as traceId, so I looked in the code and noticed it was assigning the wrong property to the field.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes