[Examples.AspNet] Update Prometheus exporter by xyq175com · Pull Request #1107 · open-telemetry/opentelemetry-dotnet-contrib

xyq175com · 2023-03-27T01:44:34Z

Examples.AspNet is referencing obsolete OpenTelemetry.Exporter.Prometheus
Fixes #1039

Changes

Update Example.AspNet to use correct reference

…Exporter.Prometheus Signed-off-by: Xu, Yan <Yan.Xu@fmr.com>

linux-foundation-easycla · 2023-03-27T01:44:37Z

The committers listed above are authorized under a signed CLA.

✅ login: xyq175com / name: yan xu (9aa7407, 029d62d)

codecov · 2023-03-27T01:57:28Z

Codecov Report

Merging #1107 (955bd2a) into main (a50e1cd) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 955bd2a differs from pull request most recent head b7d725a. Consider uploading reports for the commit b7d725a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   72.00%   71.93%   -0.08%     
==========================================
  Files         229      229              
  Lines        8438     8445       +7     
==========================================
- Hits         6076     6075       -1     
- Misses       2362     2370       +8

see 2 files with indirect coverage changes

Kielek · 2023-03-27T04:43:38Z

/easycla

xyq175com · 2023-03-27T04:45:57Z

/easycla

its passed @Kielek

Kielek

How did you tested application after changes?
It should not even compile without additional changes in Global.asax.cs.

xyq175com · 2023-03-30T22:08:31Z

Will update shortly

xyq175com · 2023-04-04T07:15:01Z

@Kielek Is there something wrong with the integration test, Same as other PR build, it has been running several hours.

Kielek · 2023-04-04T07:40:00Z

We know about issues with Code Coverage step. It is not related to your changes.
It is not a blocker for merging this PR. We need a proof (screen with prometheus page?) that your changes are working fine.

xyq175com · 2023-04-10T06:21:31Z

Hi @Kielek Do you know how to start the prometheus page? I was testing the build of Examples.AspNet is success and http://localhost:56171/ is started without error

Kielek · 2023-04-11T05:43:38Z

http://localhost:9464/metrics - based on https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.4.0/src/OpenTelemetry.Exporter.Prometheus.HttpListener/PrometheusHttpListenerOptions.cs#L26-L31

# TYPE http_server_duration_ms histogram
# UNIT http_server_duration_ms ms
# HELP http_server_duration_ms Measures the duration of inbound HTTP requests.
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="0"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="5"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="10"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="25"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="50"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="75"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="100"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="250"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="500"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="750"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="1000"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="2500"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="5000"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="7500"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="10000"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="200",le="+Inf"} 1 1681191449615
http_server_duration_ms_sum{http_method="GET",http_scheme="http",http_status_code="200"} 2697.694 1681191449615
http_server_duration_ms_count{http_method="GET",http_scheme="http",http_status_code="200"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="0"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="5"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="10"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="25"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="50"} 0 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="75"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="100"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="250"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="500"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="750"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="1000"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="2500"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="5000"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="7500"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="10000"} 1 1681191449615
http_server_duration_ms_bucket{http_method="GET",http_scheme="http",http_status_code="404",le="+Inf"} 1 1681191449615
http_server_duration_ms_sum{http_method="GET",http_scheme="http",http_status_code="404"} 69.78 1681191449615
http_server_duration_ms_count{http_method="GET",http_scheme="http",http_status_code="404"} 1 1681191449615

# EOF

but I have to apply following changes (I cannot push changes to you branch due to protection settings)

diff --git a/examples/AspNet/Views/Web.config b/examples/AspNet/Views/Web.config
index 6e67a6c..cfaf848 100644
--- a/examples/AspNet/Views/Web.config
+++ b/examples/AspNet/Views/Web.config
@@ -9,7 +9,7 @@
   </configSections>

   <system.web.webPages.razor>
-    <host factoryType="System.Web.Mvc.MvcWebRazorHostFactory, System.Web.Mvc, Version=5.2.7.0, Culture=neutral, PublicKeyToken=31BF3856AD364E35" />
+    <host factoryType="System.Web.Mvc.MvcWebRazorHostFactory, System.Web.Mvc, Version=5.2.9.0, Culture=neutral, PublicKeyToken=31BF3856AD364E35" />
     <pages pageBaseType="System.Web.Mvc.WebViewPage">
       <namespaces>
         <add namespace="System.Web.Mvc" />
@@ -34,7 +34,7 @@
   <system.web>
     <compilation>
       <assemblies>
-        <add assembly="System.Web.Mvc, Version=5.2.7.0, Culture=neutral, PublicKeyToken=31BF3856AD364E35" />
+        <add assembly="System.Web.Mvc, Version=5.2.9.0, Culture=neutral, PublicKeyToken=31BF3856AD364E35" />
         <add assembly="netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" />
       </assemblies>
     </compilation>

…y/opentelemetry-dotnet-contrib into fidelity-20230317-150933

xyq175com · 2023-04-11T06:10:04Z

@Kielek I thought that was just my local change to make it build without error, I have pushed the change to branch. Can you check again? thank you.

Fix issue#1039 Examples.AspNet is referencing obsolete OpenTelemetry.…

9aa7407

…Exporter.Prometheus Signed-off-by: Xu, Yan <Yan.Xu@fmr.com>

xyq175com requested a review from a team March 27, 2023 01:44

Merge branch 'main' into fidelity-20230317-150933

029d62d

xyq175com closed this Mar 27, 2023

xyq175com deleted the fidelity-20230317-150933 branch March 27, 2023 02:28

xyq175com restored the fidelity-20230317-150933 branch March 27, 2023 02:31

xyq175com reopened this Mar 27, 2023

Kielek reviewed Mar 27, 2023

View reviewed changes

Kielek changed the title ~~Examples.AspNet is referencing obsolete OpenTelemetry~~ [Examples.AspNet] Update Prometheus exorter Mar 27, 2023

Kielek changed the title ~~[Examples.AspNet] Update Prometheus exorter~~ [Examples.AspNet] Update Prometheus exporter Mar 27, 2023

Kielek added the dependencies Pull requests that update a dependency file label Mar 27, 2023

Update reference for exporter in global.asax.cs

955bd2a

xyq175com force-pushed the fidelity-20230317-150933 branch from 5e2410e to 955bd2a Compare April 4, 2023 04:37

Merge branch 'main' into fidelity-20230317-150933

bddff34

xyq175com requested a review from Kielek April 4, 2023 07:14

Merge branch 'main' into fidelity-20230317-150933

94cf4a7

xyq175com added 2 commits April 11, 2023 14:05

fix build error

c548b2b

Merge branch 'fidelity-20230317-150933' of https://github.com/fidelit…

03f0b9c

…y/opentelemetry-dotnet-contrib into fidelity-20230317-150933

Kielek approved these changes Apr 11, 2023

View reviewed changes

Merge branch 'main' into fidelity-20230317-150933

b7d725a

Kielek merged commit 5907573 into open-telemetry:main Apr 11, 2023

Navigation Menu

Uh oh!

[Examples.AspNet] Update Prometheus exporter - #1107

[Examples.AspNet] Update Prometheus exporter#1107
Kielek merged 8 commits into
open-telemetry:mainfrom
fidelity-contributions:fidelity-20230317-150933

xyq175com commented Mar 27, 2023

Uh oh!

linux-foundation-easycla Bot commented Mar 27, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Mar 27, 2023 •

edited

Loading

Uh oh!

Kielek commented Mar 27, 2023

Uh oh!

xyq175com commented Mar 27, 2023 •

edited

Loading

Uh oh!

Kielek left a comment

Uh oh!

xyq175com commented Mar 30, 2023

Uh oh!

xyq175com commented Apr 4, 2023

Uh oh!

Kielek commented Apr 4, 2023

Uh oh!

xyq175com commented Apr 10, 2023 •

edited

Loading

Uh oh!

Kielek commented Apr 11, 2023 •

edited

Loading

Uh oh!

xyq175com commented Apr 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xyq175com commented Mar 27, 2023

Changes

Uh oh!

linux-foundation-easycla Bot commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Kielek commented Mar 27, 2023

Uh oh!

xyq175com commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kielek left a comment

Choose a reason for hiding this comment

Uh oh!

xyq175com commented Mar 30, 2023

Uh oh!

xyq175com commented Apr 4, 2023

Uh oh!

Kielek commented Apr 4, 2023

Uh oh!

xyq175com commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kielek commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xyq175com commented Apr 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

linux-foundation-easycla Bot commented Mar 27, 2023 •

edited

Loading

codecov Bot commented Mar 27, 2023 •

edited

Loading

xyq175com commented Mar 27, 2023 •

edited

Loading

xyq175com commented Apr 10, 2023 •

edited

Loading

Kielek commented Apr 11, 2023 •

edited

Loading