Skip to content

[PersistentStorage.FileSystem] Nullable - #1085

Merged
Kielek merged 2 commits into
open-telemetry:mainfrom
Kielek:nullable-persistentstorage
Mar 17, 2023
Merged

[PersistentStorage.FileSystem] Nullable#1085
Kielek merged 2 commits into
open-telemetry:mainfrom
Kielek:nullable-persistentstorage

Conversation

@Kielek

@Kielek Kielek commented Mar 16, 2023

Copy link
Copy Markdown
Member

Towards: #894

Changes

[PersistentStorage.FileSystem] Nullable

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek
Kielek marked this pull request as ready for review March 16, 2023 08:14
@Kielek
Kielek requested a review from a team March 16, 2023 08:14
@codecov

codecov Bot commented Mar 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1085 (85ed604) into main (8f8d153) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 85ed604 differs from pull request most recent head 3b08632. Consider uploading reports for the commit 3b08632 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   69.29%   69.26%   -0.04%     
==========================================
  Files         214      212       -2     
  Lines        8358     8332      -26     
==========================================
- Hits         5792     5771      -21     
+ Misses       2566     2561       -5     
Impacted Files Coverage Δ
...Telemetry.PersistentStorage.FileSystem/FileBlob.cs 84.44% <ø> (+8.88%) ⬆️
...y.PersistentStorage.FileSystem/FileBlobProvider.cs 77.41% <ø> (+8.06%) ⬆️

... and 11 files with indirect coverage changes

@Kielek Kielek added the comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem label Mar 16, 2023
@Kielek
Kielek merged commit 6c29bc9 into open-telemetry:main Mar 17, 2023
@Kielek
Kielek deleted the nullable-persistentstorage branch March 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:persistentstorage.filesystem Things related to OpenTelemetry.PersistentStorage.FileSystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants