Skip to content

Fix: Remote storage#42

Merged
christyjacob4 merged 1 commit into
mainfrom
fix-remote-storage
Sep 25, 2023
Merged

Fix: Remote storage#42
christyjacob4 merged 1 commit into
mainfrom
fix-remote-storage

Conversation

@Meldiron

@Meldiron Meldiron commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Quick fix of a bug when using different device than local.

Nessessary before using latest version of Executor with Appwrite 1.4, otherwise all builds with cloud storage provider fails.

  • Manual QA

@Meldiron

Copy link
Copy Markdown
Contributor Author

QA:

CleanShot 2023-09-25 at 11 28 41@2x CleanShot 2023-09-25 at 11 28 47@2x CleanShot 2023-09-25 at 11 28 56@2x

@christyjacob4 christyjacob4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@christyjacob4 christyjacob4 merged commit fca4855 into main Sep 25, 2023
@stnguyen90 stnguyen90 deleted the fix-remote-storage branch September 25, 2023 17:02
Comment thread app/http.php
*/
if (!empty($source)) {
if (!$localDevice->transfer($source, $tmpSource, $sourceDevice)) {
if (!$sourceDevice->transfer($source, $tmpSource, $localDevice)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not tmpDevice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants