Update utopia-php/storage to 3.0 - #243
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThis PR upgrades the storage package to 3.0 and adapts the executor to its new API. The main changes are:
Confidence Score: 5/5The latest changes look safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Use Utopia\Http\Request in controllers f..." | Re-trigger Greptile |
| @@ -628,8 +628,6 @@ private function storeBuildCacheArtifact(string $cacheKey, string $tmpCache, Loc | |||
| $cacheDevice = $this->getBuildCacheDevice(); | |||
| $destinationArtifact = $this->getBuildCacheArtifactPath($cacheDevice, $cacheKey); | |||
|
|
|||
There was a problem hiding this comment.
Nested Cache Destination May Be Missing
When the build-cache device is local and the cache key maps to a nested path whose parent does not exist, this transfer now relies entirely on Local creating that parent. If that guarantee does not apply to device-to-device transfers, storing the cache returns false and every successful build loses its cache with a warning.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Executor/Runner/Docker.php
Line: 630
Comment:
**Nested Cache Destination May Be Missing**
When the build-cache device is local and the cache key maps to a nested path whose parent does not exist, this transfer now relies entirely on `Local` creating that parent. If that guarantee does not apply to device-to-device transfers, storing the cache returns false and every successful build loses its cache with a warning.
How can I resolve this? If you propose a fix, please make it concise.rc18 reverted the PSR-7 server request interface, so injecting ServerRequestInterface fails at runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
utopia-php/storage2.0.5 → 3.0.0 (latest), with the code changes required by the 3.0 major.Changes
utopia-php/storage: ^3.0;utopia-php/httpbumped rc16 → rc18 (rc16 pinnedutopia-php/validators ^0.2, conflicting with storage 3.0's0.3.*).Storage::DEVICE_*constants are gone; switch on theDeviceTypeenum viatryFrom(unknown schemes still fall back to Local). Acl is now theAcl::Privateenum.Device::getFiles()was removed and its replacementlistFiles()is recursive/files-only, which doesn't fit listing top-level runtime dirs in/tmp; replaced with a plainglob()on the hostname prefix (also drops the now-redundant prefix check).createDirectory()before the build-cachetransfer(): it's no longer on the abstractDevice(Local-only),Localcreates parent dirs during upload, and S3-style devices never needed it.Testing
composer analyze(phpstan) cleancomposer test:unit— 20 tests, 72 assertions passcomposer format:checkpasses🤖 Generated with Claude Code