Migrated SIDH to KEM API (issue 350)#368
Merged
dstebila merged 13 commits intoSep 17, 2018
Merged
Conversation
Contributor
Author
|
Hmm, test_kem is failing Travis's mac builds. I don't have visibility on what the problem is. @dstebila; any chance you can try locally on your machine? |
Contributor
Author
|
Fixed the issue on mac; @dstebila you can review and merge. |
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
dstebila
reviewed
Sep 13, 2018
Contributor
Author
|
Thanks for your review @dstebila; changes pushed. |
Contributor
Author
|
Simultaneously merged #358 now conflicts with this. I'm cleaning it up... |
Contributor
Author
|
Merge conflicts resolved; @dstebila ready for merge. |
dstebila
approved these changes
Sep 17, 2018
This was referenced Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated SIDH to KEM API, resolving issue #350.