Skip to content

Fix linking of test programs on msys - #1758

Merged
SWilson4 merged 1 commit into
open-quantum-safe:mainfrom
d0p1s4m4:main
Apr 23, 2024
Merged

Fix linking of test programs on msys#1758
SWilson4 merged 1 commit into
open-quantum-safe:mainfrom
d0p1s4m4:main

Conversation

@d0p1s4m4

Copy link
Copy Markdown
Contributor

Mostly related to: #1749 and #1751

  • [NO] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [NO] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@d0p1s4m4
d0p1s4m4 requested a review from dstebila as a code owner April 20, 2024 05:14

@baentsch baentsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement to the msys toolchain!

@SWilson4

Copy link
Copy Markdown
Member

Thank you very mcuh for the contribution @d0p1s4m4! Sorry to cause trivial work for you, but would you please address the failing DCO check? It should just be a matter of committing with the -s option.

Signed-off-by: d0p1 <contact@d0p1.eu>
@d0p1s4m4

Copy link
Copy Markdown
Contributor Author

@SWilson4 done

@SWilson4

Copy link
Copy Markdown
Member

Thank you very much!

@SWilson4
SWilson4 merged commit edfed5f into open-quantum-safe:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants