Fix linking of test programs on msys - #1758
Merged
Merged
Conversation
dstebila
approved these changes
Apr 20, 2024
baentsch
approved these changes
Apr 21, 2024
baentsch
left a comment
Member
There was a problem hiding this comment.
Thanks for this improvement to the msys toolchain!
Member
|
Thank you very mcuh for the contribution @d0p1s4m4! Sorry to cause trivial work for you, but would you please address the failing DCO check? It should just be a matter of committing with the |
SWilson4
approved these changes
Apr 22, 2024
Signed-off-by: d0p1 <contact@d0p1.eu>
Contributor
Author
|
@SWilson4 done |
Member
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly related to: #1749 and #1751