Add shared library build to testing system

[dstebila]

On nist-branch we build test_kem (which statically links against liboqs.a) and test_kem_shared (which dynamically links against liboqs.so) and test both of them in Travis. Is there a way to do that on master branch?

[dstebila]

Depends on #358.

[smashra]

Mac builds are failing because of utilities.c contain no symbols.
The only way I could come up to fix it is disable static library build on Mac.
But I'm not sure if we want to disable static build of liboqs on Mac.
May be Nir can look into this.

[dstebila]

The failure has nothing to do with the message about utilities.c containing no symbols.

It has something to do with how clang tries to build static executables on macOS.

Run the following command on macOS:

CC_OVERRIDE=clang AES_NI=0 USE_OPENSSL=1 OPENSSL_DIR=/usr/local/opt/openssl .travis/all-tests.sh

The last few lines of output look like this:

Making all in .
  CCLD     liboqs.la
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l5_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l5_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l5_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l5_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l5_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l1_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l3_la-utilities.o) has no symbols
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l5_la-utilities.o) has no symbols
Making all in tests
make[2]: Nothing to be done for `all'.
checking for a BSD-compatible install... /usr/local/bin/ginstall -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/local/bin/gmkdir -p
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-apple-darwin17.7.0
checking host system type... x86_64-apple-darwin17.7.0
checking how to print strings... printf
checking for gcc... clang
checking whether the C compiler works... no
configure: error: in `/Users/dstebila/Desktop/liboqs-master':
configure: error: C compiler cannot create executables
See `config.log' for more details

Ignore the lines about utilities.o containing no symbols, those are just warnings.

Notice that liboqs.la was built successfully, then it says "Making all in tests", and then says "Nothing to be done for all", and then looks like it's running configure again. This configure is what's failing. I'm not actually sure why it's running configure again, but it apparently is. If you look in config.log, you'll see how it fails. On my system here is the relevant extract from config.log:

InstalledDir: /Library/Developer/CommandLineTools/usr/bin
configure:3969: $? = 0
configure:3958: clang -V >&5
clang: error: argument to '-V' is missing (expected 1 value)
clang: error: no input files
configure:3969: $? = 1
configure:3958: clang -qversion >&5
clang: error: unknown argument: '-qversion'
clang: error: no input files
configure:3969: $? = 1
configure:3989: checking whether the C compiler works
configure:4011: clang   -static conftest.c  >&5
ld: library not found for -lcrt0.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
configure:4015: $? = 1

The key error message I think is "library not found for -lcrt0.o". Googling this error message yields the following StackExchange discussion: https://stackoverflow.com/questions/3801011/ld-library-not-found-for-lcrt0-o-on-osx-10-6-with-gcc-clang-static-flag

Can you investigate from there?

[smashra]

The problem turned out to be very simple, instead of passing LDFLAGS='-static' all that needs to be passed is --enable-shared=no for static build. That works fine on both Linux and Mac. So static builds are not an issue on Mac. Empty .o files generated by bike will only be an issue if we consider -Werror. Otherwise nothing spectacular.

…

On Tue, Sep 18, 2018 at 12:41 PM Douglas Stebila ***@***.***> wrote: The failure has nothing to do with the message about utilities.c containing no symbols. It has something to do with how clang tries to build static executables on macOS. Run the following command on macOS: CC_OVERRIDE=clang AES_NI=0 USE_OPENSSL=1 OPENSSL_DIR=/usr/local/opt/openssl .travis/all-tests.sh The last few lines of output look like this: Making all in . CCLD liboqs.la /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l5_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l5_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l5_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike1_l5_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike2_l5_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l1_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l3_la-utilities.o) has no symbols /Library/Developer/CommandLineTools/usr/bin/ranlib: file: .libs/liboqs.a(libkembike3_l5_la-utilities.o) has no symbols Making all in tests make[2]: Nothing to be done for `all'. checking for a BSD-compatible install... /usr/local/bin/ginstall -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /usr/local/bin/gmkdir -p checking for gawk... no checking for mawk... no checking for nawk... no checking for awk... awk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking build system type... x86_64-apple-darwin17.7.0 checking host system type... x86_64-apple-darwin17.7.0 checking how to print strings... printf checking for gcc... clang checking whether the C compiler works... no configure: error: in `/Users/dstebila/Desktop/liboqs-master': configure: error: C compiler cannot create executables See `config.log' for more details Ignore the lines about utilities.o containing no symbols, those are just warnings. Notice that liboqs.la was built successfully, then it says "Making all in tests", and then says "Nothing to be done for all", and then looks like it's running configure again. This configure is what's failing. I'm not actually sure why it's running configure again, but it apparently is. If you look in config.log, you'll see how it fails. On my system here is the relevant extract from config.log: InstalledDir: /Library/Developer/CommandLineTools/usr/bin configure:3969: $? = 0 configure:3958: clang -V >&5 clang: error: argument to '-V' is missing (expected 1 value) clang: error: no input files configure:3969: $? = 1 configure:3958: clang -qversion >&5 clang: error: unknown argument: '-qversion' clang: error: no input files configure:3969: $? = 1 configure:3989: checking whether the C compiler works configure:4011: clang -static conftest.c >&5 ld: library not found for -lcrt0.o clang: error: linker command failed with exit code 1 (use -v to see invocation) configure:4015: $? = 1 The key error message I think is "library not found for -lcrt0.o". Googling this error message yields the following StackExchange discussion: https://stackoverflow.com/questions/3801011/ld-library-not-found-for-lcrt0-o-on-osx-10-6-with-gcc-clang-static-flag Can you investigate from there? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANmJw_tDkz5_3S4IA6lM5l4ExerVq42Vks5ucSI3gaJpZM4VUt6m> .

[dstebila]

Resolved by #358