Skip to content

[Fix] Fix knn multi-gpu bug - #634

Merged
fangyixiao18 merged 11 commits into
open-mmlab:dev-1.xfrom
fangyixiao18:knn
Dec 23, 2022
Merged

[Fix] Fix knn multi-gpu bug#634
fangyixiao18 merged 11 commits into
open-mmlab:dev-1.xfrom
fangyixiao18:knn

Conversation

@fangyixiao18

Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Multi-gpu results and single gpu results
image
image

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov

codecov Bot commented Dec 16, 2022

Copy link
Copy Markdown

Codecov Report

Base: 81.61% // Head: 82.11% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (9297cb9) compared to base (fbe0ff6).
Patch coverage: 12.90% of modified lines in pull request are covered.

❗ Current head 9297cb9 differs from pull request most recent head 2ca9f0b. Consider uploading reports for the commit 2ca9f0b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #634      +/-   ##
===========================================
+ Coverage    81.61%   82.11%   +0.50%     
===========================================
  Files          135      135              
  Lines         4961     4921      -40     
  Branches       672      660      -12     
===========================================
- Hits          4049     4041       -8     
+ Misses         774      743      -31     
+ Partials       138      137       -1     
Flag Coverage Δ
unittests 82.11% <12.90%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/engine/hooks/deepcluster_hook.py 38.88% <0.00%> (-0.55%) ⬇️
mmselfsup/utils/gather.py 100.00% <ø> (+73.33%) ⬆️
mmselfsup/utils/collect.py 14.63% <8.33%> (-4.88%) ⬇️
mmselfsup/models/utils/extractor.py 53.33% <25.00%> (-0.84%) ⬇️
mmselfsup/utils/__init__.py 100.00% <100.00%> (ø)
mmselfsup/datasets/transforms/processing.py 89.00% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread mmselfsup/engine/hooks/deepcluster_hook.py
Comment thread tools/benchmarks/classification/knn_imagenet/test_knn.py Outdated
Comment thread tools/benchmarks/classification/knn_imagenet/test_knn.py Outdated
@fangyixiao18
fangyixiao18 merged commit b6585cc into open-mmlab:dev-1.x Dec 23, 2022
@fangyixiao18 fangyixiao18 mentioned this pull request Dec 23, 2022
6 tasks
@fangyixiao18
fangyixiao18 deleted the knn branch December 27, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants