Add discovery_path option for non-standard discovery document paths - #214
Open
alexplatteeuw wants to merge 2 commits into
Open
Add discovery_path option for non-standard discovery document paths#214alexplatteeuw wants to merge 2 commits into
discovery_path option for non-standard discovery document paths#214alexplatteeuw wants to merge 2 commits into
Conversation
New option discovery_path, passed through to Config.discover! when set. Allows using discovery mode with providers that publish their configuration at a non-standard path.
alexplatteeuw
marked this pull request as ready for review
May 29, 2026 06:57
Use keyword splat instead of branching with an artificial empty hash for cache_options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Some providers run Keycloak (or similar) behind a custom login frontend. The standard
.well-known/openid-configurationgenerated by Keycloak advertises its own/authasauthorization_endpoint, but users actually authenticate through the custom frontend (smartcard login, hardware MFA, etc.). The Keycloak endpoint itself doesn't render a usable login page.These providers publish a second discovery document at a different path that overrides
authorization_endpointto point to the real login UI, while keeping everything else (token, userinfo, jwks, issuer) identical. We've hit this with Pro Sante Connect (French national health ID, uses.well-known/wallet-openid-configuration).Right now the only workaround is to disable discovery and hardcode all endpoints.
Change
New option
discovery_path, passed through toConfig.discover!when set, ignored otherwise.Depends on the companion PR nov/openid_connect#113 that adds
discovery_pathtoResource#initializeandConfig.discover!.Related: #120