OMERO documentation job#72
Merged
Merged
Conversation
This job can be used to review documentation PRs alongside the code PR provided that the same development branch exists on the documentation repository.
Member
Generally, 👍 |
Member
Author
|
Re push job, we could easily create an extra job e.g. Re single landing page, I had the same feeling when working through #74 (comment). Might need some more thoughts - I would assume that's something that would need to be generated post deployment to retrieve the dynamic ports. |
Member
|
I don't know if there's a pressing need. It might be easier for us to move to the single |
Member
Author
|
Makes sense. Shall we merge as it is then and capture the landing page RFE as an issue? |
Open
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/ccx2knE7/141-check-whether-sphinx-can-be-upgraded-for-all-docs-jobs
Prior to upgrading the Sphinx dependency on our production CI, this PR ports recent additions allowing to:
To test this PR, review https://minke.openmicroscopy.org:32833/job/OMERO-docs/