Skip to content

use node 16#200

Merged
jburel merged 1 commit into
ome:masterfrom
jburel:update_node
Jun 6, 2023
Merged

use node 16#200
jburel merged 1 commit into
ome:masterfrom
jburel:update_node

Conversation

@jburel

@jburel jburel commented Jan 12, 2023

Copy link
Copy Markdown
Member

This PR upgrades the node version.
This has been tested in the upgraded CI.

@jburel jburel requested a review from will-moore January 12, 2023 10:46
@jburel jburel mentioned this pull request Jan 12, 2023
@will-moore

Copy link
Copy Markdown
Member

Is there a reason to pick node v16 specifically?
Looks like v18 is the latest LTS: https://nodejs.org/en/download/

@jburel

jburel commented Jan 12, 2023

Copy link
Copy Markdown
Member Author

The reason I picked 16 is to match https://github.com/ome/omero-figure/blob/master/.omeroci/app-deps
We could bump to 18 in figure and see. I have no objection to it

@will-moore

Copy link
Copy Markdown
Member

Ah - I see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-web/1533/console just failed with my figure PR: ome/omero-figure#477

18:21:24     /tmp/pip-install-k93fdtkn/omero-figure_f3c59f5784fe4defb69418a41926d86f/node_modules/vite/bin/vite.js:2
18:21:24     import { performance } from 'node:perf_hooks'
18:21:24            ^
18:21:24     
18:21:24     SyntaxError: Unexpected token {

I have been developing with this version locally:

$ node --version
v16.14.0
$ npm --version
8.13.1

@will-moore

Copy link
Copy Markdown
Member

I've reverted that figure PR to "draft" (until node is updated) so as not to break the omero-web job.

@jburel jburel merged commit f92ef45 into ome:master Jun 6, 2023
@jburel jburel deleted the update_node branch December 17, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants