Jenkins#190
Conversation
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
A few comments primarily regarding the management of the plugins/Jenkins moving forward. Otherwise the management of the omero-server/omero-web user and the reduction of the omero_install complexity is inline with my understanding of the changes proposed in ome/omero-install#261.
| matrix-auth:2.3 | ||
| icon-shim:2.0.3 | ||
| authentication-tokens:1.3 | ||
| swarm |
There was a problem hiding this comment.
So the new strategy is to stop tracking pinned versions of the plugins? From my side that would reduce maintenance but I wonder what the impact will be when breaking changes are made to the plugin. Would this prevent a deployment as the job configuration are not in-sync?
There was a problem hiding this comment.
Pinning the version leads to errors again i.e. unable to find plugins etc.
Test:
- install without pinning
- run script to get the version of each plugin
- install with pin version
- failure
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
Barring the ongoing question on the plugins versions, the state of the changes looks good to me. It effectively brings Jenkins to the current LTS, simplifies several installation steps and clarifies a few assumptions in the README. Should we get this merged and move towards the deployment of an updated version of merge-ci/latest-ci ?
|
I think we need to agree on modified logic introduced in ome/omero-py#316 and ome/openmicroscopy#6301 since they both have implications on the job configurations. Note that this PR does not include the change to support ome/omero-documentation#2195. Happy to push a commit to that effect. |
|
Similarly to the ongoing work on CentOS7/Python 3.8, my vote would be for separating the work on the OMERO documentation hosting by readthedocs at least as a follow-up PR and keep this focused on the Jenkins LTS upgrade. |
|
I agree. This was just mentioned for info |
|
Merging and proposing to tag 0.16. If any objection |
2 participants
This PR updates jenkins to LTS version
Usage of personal branch will be removed when ome/omero-install#261 is merged and enew version available in docker file.
Note: Commits could be squashed since many commits have been made during the investigation
Reference #188