Update#21
Merged
Merged
Conversation
sbesson
approved these changes
Feb 1, 2022
sbesson
left a comment
sbesson
left a comment
Member
There was a problem hiding this comment.
The proposed changes read well. Since the downstream repositories are consuming tags of this Docker image, should we just get this merged and tagged and iterate ? The omero-install cleanup can happen in a separate PR or be captured as an issue.
Also should we use the occasion to add the logic to push to DockerHub in the GitHub workflow?
Member
Author
|
Yes I was planning to add the logic to push to Dockerhub in a separate PR |
Member
Works for me. Happy to see this merged immediately then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates version
One option could also to remove the checkout of
omero-installand checkout the repository in the various Dockerfile files in devspace.
Note that there is the possibility in the Dockerfile files to override the version of omero-install deployed