Skip to content

ImGuiTabBarFlags_NoSeparator flag #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mewiof wants to merge 3 commits into from
Closed

ImGuiTabBarFlags_NoSeparator flag #6820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
072308c
"ImGuiTabItemFlags_NoTrimming" flag
mewiof Sep 14, 2023
096b007
Revert ""ImGuiTabItemFlags_NoTrimming" flag"
mewiof Sep 15, 2023
7c70dee
tab_bar->VisibleSeparator
mewiof Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions imgui_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2768,6 +2768,7 @@ struct IMGUI_API ImGuiTabBar
bool WantLayout;
bool VisibleTabWasSubmitted;
bool TabsAddedNew; // Set to true when a new tab item or button has been added to the tab bar during last frame
bool VisibleSeparator; // Bottom Line
ImS16 TabsActiveCount; // Number of tabs submitted this frame.
ImS16 LastTabItemIdx; // Index of last BeginTabItem() tab for use by EndTabItem()
float ItemSpacingY;
Expand Down
15 changes: 12 additions & 3 deletions imgui_widgets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7720,8 +7720,13 @@ bool ImGui::BeginTabBarEx(ImGuiTabBar* tab_bar, const ImRect& tab_bar_bb, ImG
// Set cursor pos in a way which only be used in the off-chance the user erroneously submits item before BeginTabItem(): items will overlap
window->DC.CursorPos = ImVec2(tab_bar->BarRect.Min.x, tab_bar->BarRect.Max.y + tab_bar->ItemSpacingY);

// Draw separator
// Separator visibility
const ImU32 col = GetColorU32((flags & ImGuiTabBarFlags_IsFocused) ? ImGuiCol_TabActive : ImGuiCol_TabUnfocusedActive);
tab_bar->VisibleSeparator = (col & IM_COL32_A_MASK) != 0;
if (tab_bar->VisibleSeparator == false)
return true;

// Draw separator
const float y = tab_bar->BarRect.Max.y - 1.0f;
if (dock_node != NULL)
{
Expand Down Expand Up @@ -8486,6 +8491,10 @@ bool ImGui::TabItemEx(ImGuiTabBar* tab_bar, const char* label, bool* p_open,
else if (p_open == NULL)
flags |= ImGuiTabItemFlags_NoCloseButton;

// There is no need for trimming if the separator is not drawn
if (tab_bar->VisibleSeparator == false)
flags |= ImGuiTabItemFlags_Preview;

// Acquire tab data
ImGuiTabItem* tab = TabBarFindTabByID(tab_bar, id);
bool tab_is_new = false;
Expand Down Expand Up @@ -8777,13 +8786,13 @@ ImVec2 ImGui::TabItemCalcSize(ImGuiWindow* window)

void ImGui::TabItemBackground(ImDrawList* draw_list, const ImRect& bb, ImGuiTabItemFlags flags, ImU32 col)
{
// While rendering tabs, we trim 1 pixel off the top of our bounding box so they can fit within a regular frame height while looking "detached" from it.
ImGuiContext& g = *GImGui;
const float width = bb.GetWidth();
IM_UNUSED(flags);
IM_ASSERT(width > 0.0f);
const float rounding = ImMax(0.0f, ImMin((flags & ImGuiTabItemFlags_Button) ? g.Style.FrameRounding : g.Style.TabRounding, width * 0.5f - 1.0f));
const float y1 = bb.Min.y + 1.0f;
// Trim both the top and bottom by 1 pixel for proportionality, keeping the content centered
const float y1 = bb.Min.y + ((flags & ImGuiTabItemFlags_Preview) ? 0.0f : 1.0f);
const float y2 = bb.Max.y + ((flags & ImGuiTabItemFlags_Preview) ? 0.0f : -1.0f);
draw_list->PathLineTo(ImVec2(bb.Min.x, y2));
draw_list->PathArcToFast(ImVec2(bb.Min.x + rounding, y1 + rounding), rounding, 6, 9);
Expand Down