Skip to content

STM clean-up - #63

Merged
jmid merged 4 commits into
mainfrom
stm-cleanup
May 18, 2022
Merged

STM clean-up#63
jmid merged 4 commits into
mainfrom
stm-cleanup

Conversation

@jmid

@jmid jmid commented May 10, 2022

Copy link
Copy Markdown
Collaborator

This PR cleans up the STM signature, leaving the repeat-retries combination property, which has worked well for Lin.

Currently, the numbers are set to repeat:25 and retries:15. We may want to adjust these before merging.

As a bonus

  • it adds a negative int64 ref test
  • removes a bit of whitespace

As an extra bonus, with the changes the Buffer test can segfault my local Linux running:

$ dune exec src/buffer/buffer_stm_test.exe -- -v -s 81407870

I'm therefore curious how the Linux CI reacts...

@jmid

jmid commented May 10, 2022

Copy link
Copy Markdown
Collaborator Author

I should add that the Lazy tests take a while to run with these parameter numbers, which is why I am curious to reduce them...

@jmid

jmid commented May 10, 2022

Copy link
Copy Markdown
Collaborator Author

@jmid

jmid commented May 15, 2022

Copy link
Copy Markdown
Collaborator Author

Rerunning jobs as trunk has now been patched for the MacOS segfault.

@jmid jmid mentioned this pull request May 17, 2022
@jmid

jmid commented May 18, 2022

Copy link
Copy Markdown
Collaborator Author

Given the MacOS CI red light, I've instead completed three successful runs of the test suite on the MacMini - and therefore declare this ready for merge! 😃

@jmid
jmid merged commit cdc42d3 into main May 18, 2022
@jmid
jmid deleted the stm-cleanup branch May 18, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant