rofl-scheduler: Per-offer allowed_creators and allowed_artifacts - #2465
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
from
May 25, 2026 09:23
2c74a06 to
c494bee
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
- Coverage 51.33% 51.24% -0.10%
==========================================
Files 237 237
Lines 17132 17212 +80
==========================================
+ Hits 8795 8820 +25
- Misses 8277 8332 +55
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
from
May 25, 2026 11:10
bb27b06 to
a1e2bc6
Compare
matevz
reviewed
May 25, 2026
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
from
May 25, 2026 11:48
950f9e1 to
ed25373
Compare
anzoman
marked this pull request as ready for review
May 25, 2026 11:58
kostko
reviewed
May 26, 2026
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
2 times, most recently
from
May 28, 2026 13:48
6a98181 to
e2be17f
Compare
Add per-offer overrides for `allowed_creators` and `allowed_artifacts` so that a single scheduler can host both public and internal workloads without repeating the global allowlist for every offer.
Support mixed array entries: plain strings (old format) alongside single-key maps with per-offer overrides, so existing configs need no changes.
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
from
May 28, 2026 14:35
e2be17f to
389c1db
Compare
kostko
reviewed
May 29, 2026
kostko
left a comment
Member
There was a problem hiding this comment.
Looks good, have you tested it anywhere?
anzoman
force-pushed
the
anzoman/feature/rofl-scheduler-per-offer-config
branch
from
June 1, 2026 10:39
389c1db to
2a5dd44
Compare
kostko
approved these changes
Jun 1, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jun 1, 2026
…nzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
github-actions Bot
added a commit
that referenced
this pull request
Jun 1, 2026
…nzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
github-actions Bot
added a commit
that referenced
this pull request
Jun 1, 2026
…/anzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jun 1, 2026
…sisprotocol/anzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jun 1, 2026
…sisprotocol/anzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jun 1, 2026
…oasisprotocol/anzoman/feature/rofl-scheduler-per-offer-config rofl-scheduler: Per-offer allowed_creators and allowed_artifacts 9d70f5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-offer overrides for
allowed_creatorsandallowed_artifacts, making it possible to mix public and internal workloads on the same scheduler instance without repeating the global allowlist for every offer.What changed
offersis now aBTreeMap<String, OfferConfig>internally. Each entry carries optionalallowed_creatorsandallowed_artifactsoverrides; when absent, the top-level value is used as a fallback. Empty list = allow all.offer_key_by_idis built once per scheduling round indiscover()and reused inprocess_pending(), avoiding a redundant on-chain fetch.idfield.Config