Skip to content

fix: remove dependency to parse-git-config - #250

Merged
danielroe merged 1 commit into
nuxt:mainfrom
thomashohn:fix/remove-depency-to-parse-git-config-248
Mar 18, 2025
Merged

fix: remove dependency to parse-git-config#250
danielroe merged 1 commit into
nuxt:mainfrom
thomashohn:fix/remove-depency-to-parse-git-config-248

Conversation

@thomashohn

@thomashohn thomashohn commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolves #248

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR attempts to remove the dependency to the parse-git-config, which has not been released for
7 years and might not be released. Instead it uses a raw git command to fetch the remote.origin.url

@thomashohn
thomashohn requested a review from danielroe as a code owner March 18, 2025 05:55
@danielroe
danielroe merged commit 92cfb9e into nuxt:main Mar 18, 2025
@hugobytebender

Copy link
Copy Markdown

Hi @thomashohn! - I am not familiar with nuxt.js framework but I am running nuxt@2.17.1 in my project and it is looking like that this version is pulling this dependency called @nuxt/telemetry@1.5.0 uses parse-git-config v3.0.0. I want to stay away from v1.5.0 and upgrade @nuxt/telemetry@2.6.6 to stay away from parse-git-config. Do I need to upgrade this version nuxt@2.17.1 also?

@thomashohn

Copy link
Copy Markdown
Contributor Author

Hi @hugobytebender

Yes i believe so @nuxt/telemetry@2.6.6 requires nuxt 3 which also soon will EOL (31 Jan 2026) - so I would think that there will/should be a version of this package that will support nuxt 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerability

3 participants