Recognize PEP 604 parameter annotations#894
Open
8rief wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PythonTranslator.inspectcurrently skips parameters annotated with PEP 604union syntax because its annotation pattern does not accept
|. As a result,a valid parameter such as
value: str | None = Noneis omitted from notebookinspection and is reported as unknown when overridden.
This change accepts the union operator in Python annotations and adds
regression cases for both
None | strandlist[str] | None.Fixes #806
Testing
python -m pytest papermill/tests/test_translators.py::test_inspect_python -qpython -m pytest papermill/tests/test_translators.py -qpython -m pytest -qpre-commit run --files papermill/translators.py papermill/tests/test_translators.pycheck-manifest