Skip to content

GH-202 - do not report NS500 for event subscriptions - #203

Merged
tpodolak merged 1 commit into
devfrom
GH-202-received-event-subscription
Jul 30, 2023
Merged

GH-202 - do not report NS500 for event subscriptions#203
tpodolak merged 1 commit into
devfrom
GH-202-received-event-subscription

Conversation

@tpodolak

Copy link
Copy Markdown
Member

Closes #202

@tpodolak
tpodolak force-pushed the GH-202-received-event-subscription branch from a962a48 to 81662df Compare February 18, 2023 16:36
@coveralls

coveralls commented Feb 18, 2023

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 533

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.109%

Totals Coverage Status
Change from base Build 530: 0.0%
Covered Lines: 2654
Relevant Lines: 2733

💛 - Coveralls

{{
public class Foo
{{
public event Action SomeEvent;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this comment I think this should report NS1001.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@tpodolak tpodolak Jul 18, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtchepak I've removed code not related with #202 so this PR now only solves original bug. Will handle reporting of NS1001 for event subscription checks in separate PR - here is a task to track it #207

@tpodolak
tpodolak force-pushed the GH-202-received-event-subscription branch from 81662df to 60d6225 Compare July 18, 2023 11:56
@tpodolak
tpodolak merged commit 3edadcb into dev Jul 30, 2023
@tpodolak
tpodolak deleted the GH-202-received-event-subscription branch July 30, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NS5000 when checking if an event subscription was received.

3 participants