fix(release): ignore deleted projects in historical affectedness - #36538
Merged
JamesHenry merged 2 commits intoAug 3, 2026
Merged
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 5ad319f
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
JamesHenry
marked this pull request as ready for review
August 1, 2026 17:47
JamesHenry
enabled auto-merge (squash)
August 1, 2026 17:48
JamesHenry
disabled auto-merge
August 1, 2026 17:49
JamesHenry
enabled auto-merge (squash)
August 1, 2026 17:49
leosvelperez
approved these changes
Aug 3, 2026
ryanhefner
pushed a commit
to ryanhefner/nx
that referenced
this pull request
Aug 4, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx Release evaluates historical commits against the current project graph and filesystem. If a historical commit touched a project configuration that no longer exists, the generic affectedness deletion fallback marks every current project as affected. In independent release groups, this can cause unrelated surviving projects to receive version bumps for commits belonging only to a retired project.
Expected Behavior
Historical release commit attribution disables only the conservative “project deletion affects every project” fallback. Other affectedness locators continue to run, and generic
nx affectedbehavior retains its existing conservative default.The change includes focused unit coverage for both the configurable fallback and continued locator execution, plus an end-to-end independent-release reproduction with a retired project.
Related Issue(s)
Fixes #33374