Skip to content

fix(release): ignore deleted projects in historical affectedness - #36538

Merged
JamesHenry merged 2 commits into
nrwl:masterfrom
AI-JamesHenry-Org:fix/release-deleted-project-affectedness
Aug 3, 2026
Merged

fix(release): ignore deleted projects in historical affectedness#36538
JamesHenry merged 2 commits into
nrwl:masterfrom
AI-JamesHenry-Org:fix/release-deleted-project-affectedness

Conversation

@AI-JamesHenry

Copy link
Copy Markdown
Contributor

Current Behavior

Nx Release evaluates historical commits against the current project graph and filesystem. If a historical commit touched a project configuration that no longer exists, the generic affectedness deletion fallback marks every current project as affected. In independent release groups, this can cause unrelated surviving projects to receive version bumps for commits belonging only to a retired project.

Expected Behavior

Historical release commit attribution disables only the conservative “project deletion affects every project” fallback. Other affectedness locators continue to run, and generic nx affected behavior retains its existing conservative default.

The change includes focused unit coverage for both the configurable fallback and continued locator execution, plus an end-to-end independent-release reproduction with a retired project.

Related Issue(s)

Fixes #33374

@netlify

netlify Bot commented Aug 1, 2026

Copy link
Copy Markdown

👷 Deploy request for nx-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5ad319f

@netlify

netlify Bot commented Aug 1, 2026

Copy link
Copy Markdown

👷 Deploy request for nx-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5ad319f

@nx-cloud

nx-cloud Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 5ad319f

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 15m 42s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 1m View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 18s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-01 17:46:05 UTC

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:

git commit --allow-empty -m "chore: trigger rerun"
git push

Nx Cloud View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@JamesHenry
JamesHenry marked this pull request as ready for review August 1, 2026 17:47
@JamesHenry
JamesHenry requested a review from a team as a code owner August 1, 2026 17:47
@JamesHenry
JamesHenry requested a review from leosvelperez August 1, 2026 17:47
@JamesHenry
JamesHenry enabled auto-merge (squash) August 1, 2026 17:48
@JamesHenry JamesHenry changed the title fix(release): ignore retired projects in historical affectedness fix(release): ignore deleted projects in historical affectedness Aug 1, 2026
@JamesHenry
JamesHenry disabled auto-merge August 1, 2026 17:49
@JamesHenry
JamesHenry enabled auto-merge (squash) August 1, 2026 17:49
@JamesHenry
JamesHenry merged commit 83eee02 into nrwl:master Aug 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting or renaming a project causes every project to be released + versioned

3 participants