chore(misc): calibrate PR review pipeline from maintainer review feedback - #36433
Merged
Conversation
…back Derived from diffing the pipeline's drafts against the maintainer's manual reviews of the same PRs (nx#36370, nx#35863): - review-pr: add PIPELINE_VERSION to the dedup so drafts from older criteria generations re-review at an unchanged head SHA; keep a capped non-verdict-driving Suggestions tier instead of discarding it; require a Maintainer-calls section surfacing endorsed debatable design decisions; add an editorial-direction check for astro-docs changes - security-analyzer: design pass for security-mechanism PRs (fail-closed over fail-open, exact comparison, perms at creation, throw on world-shared tmpdir); laxer deliberate choices become maintainer calls - performance-analyzer: full-workspace iteration earns an advisory stress-test ask even on cold paths
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit da071d1
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The in-repo PR review pipeline (
.claude/skills/review-pr+ analyzer agents) diverged from maintainer judgment on a recent batch: it verdicted lgtm on a security-hardening PR the maintainer then requested changes on. Structurally:Expected Behavior
### Maintainer callssection — one line per endorsed debatable decision (choice / stricter alternative / trade-off) — and a capped, non-verdict-driving### Suggestionstier.PIPELINE_VERSIONconstant in the dedup ages out drafts from older criteria generations instead of pinning them at an unchanged head SHA.Related Issue(s)
N/A — calibration derived from diffing the pipeline's drafts against the maintainer's manual reviews of the same PRs (#36370, #35863).
View session information ↗