fix(core): handle colons in target name when resolving inputs to generate graph - #36429
Merged
Conversation
Fixes nrwl#33710. Uses colon-aware parsing for determining targets instead of basic string split
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
FrozenPandaz
approved these changes
Jul 22, 2026
FrozenPandaz
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contribution! LGTM 🎉
Contributor
|
View your CI Pipeline Execution ↗ for commit 042455e
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
Contributor
Author
|
Thanks @FrozenPandaz! Anything i need to do to merge it? |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 29, 2026
…rate graph (#36429) ## Current Behavior If a project target has a colon in its name, its input are not computed correctly when using the `graph` command. ## Expected Behavior Targets with colons in their name should be computed correctly. ## Related Issue(s) Fixes #33710 (cherry picked from commit 2865a0d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
If a project target has a colon in its name, its input are not computed correctly when using the
graphcommand.Expected Behavior
Targets with colons in their name should be computed correctly.
Related Issue(s)
Fixes #33710