Skip to content

fix(core): handle colons in target name when resolving inputs to generate graph - #36429

Merged
FrozenPandaz merged 1 commit into
nrwl:masterfrom
lourd:lou/colon-in-target
Jul 23, 2026
Merged

fix(core): handle colons in target name when resolving inputs to generate graph#36429
FrozenPandaz merged 1 commit into
nrwl:masterfrom
lourd:lou/colon-in-target

Conversation

@lourd

@lourd lourd commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Current Behavior

If a project target has a colon in its name, its input are not computed correctly when using the graph command.

Expected Behavior

Targets with colons in their name should be computed correctly.

Related Issue(s)

Fixes #33710

Fixes nrwl#33710. Uses colon-aware parsing for determining targets instead of basic string split
@lourd
lourd requested a review from a team as a code owner July 21, 2026 14:30
@lourd
lourd requested a review from AgentEnder July 21, 2026 14:30
@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

👷 Deploy request for nx-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 042455e

@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

👷 Deploy request for nx-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 042455e

@FrozenPandaz FrozenPandaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@nx-cloud

nx-cloud Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 042455e

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 17m 21s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 1m 3s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 19s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-22 20:16:43 UTC

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:

git commit --allow-empty -m "chore: trigger rerun"
git push

Nx Cloud View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@lourd

lourd commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @FrozenPandaz! Anything i need to do to merge it?

@FrozenPandaz
FrozenPandaz merged commit 2865a0d into nrwl:master Jul 23, 2026
20 of 22 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2026
…rate graph (#36429)

## Current Behavior

If a project target has a colon in its name, its input are not computed
correctly when using the `graph` command.

## Expected Behavior

Targets with colons in their name should be computed correctly.

## Related Issue(s)

Fixes #33710

(cherry picked from commit 2865a0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

target name with a colon not showing inputs correctly

2 participants