fix(core): correct the 22.6.0 gitignore and analytics migration wiring - #36356
Merged
Conversation
A merge conflict during the move to the `./dist/...` build layout mispointed the `22-6-0-add-claude-settings-local-to-git-ignore` migration at `update-17-3-0/update-nxw` and dropped the `22-6-0-enable-analytics-prompt` entry entirely. From 22.6.2 / 22.7.0-beta.2 onward, workspaces crossing 22.6.0-rc.0 ran the nx-wrapper update instead of adding `.claude/settings.local.json` to `.gitignore`, and the analytics-prompt migration stopped shipping. Repoint the gitignore migration at its real implementation (version left at 22.6.0-rc.0) and restore the analytics-prompt entry at its original 22.6.0-beta.11. To prevent a recurrence, `assertValidMigrationPaths` now fails when a migration entry-point file (a top-level `.ts` with a default export under a version dir) is referenced by no migrations.json entry. The reverse check catches both a stranded target and a leftover unwired file. It surfaced `update-17-3-0/nx-release-path`, an unwired migration dead since 2023, now removed.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 64a6e99
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Jul 15, 2026
AgentEnder
pushed a commit
that referenced
this pull request
Jul 17, 2026
#36356) ## Current Behavior A merge conflict during the move to the `./dist/...` build layout left two Nx core migrations miswired. The `22-6-0-add-claude-settings-local-to-git-ignore` migration pointed at `update-17-3-0/update-nxw`, so from 22.6.2 / 22.7.0-beta.2 onward, workspaces migrating across 22.6.0-rc.0 ran the nx-wrapper update instead of adding `.claude/settings.local.json` to `.gitignore`. The `22-6-0-enable-analytics-prompt` entry was dropped entirely, so that migration stopped shipping after 22.6.1. ## Expected Behavior The gitignore migration runs its real implementation (version left at 22.6.0-rc.0), and the analytics-prompt migration is wired again at its original 22.6.0-beta.11. `assertValidMigrationPaths` now fails when a migration entry-point file (a top-level `.ts` with a default export under a version dir) is referenced by no `migrations.json` entry, so a stranded or leftover migration file is caught in CI. That reverse check surfaced `update-17-3-0/nx-release-path`, an unwired migration dead since 2023, which is removed. ## Related Issue(s) Fixes NXC-4670 <!-- polygraph-session-start --> --- [View session information ↗](https://app.trypolygraph.com/orgs/6a061dcb561c062131116eca/sessions/fix-migrate-misc-issues-cfee7d13) <!-- polygraph-session-end -->
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 20, 2026
#36356) ## Current Behavior A merge conflict during the move to the `./dist/...` build layout left two Nx core migrations miswired. The `22-6-0-add-claude-settings-local-to-git-ignore` migration pointed at `update-17-3-0/update-nxw`, so from 22.6.2 / 22.7.0-beta.2 onward, workspaces migrating across 22.6.0-rc.0 ran the nx-wrapper update instead of adding `.claude/settings.local.json` to `.gitignore`. The `22-6-0-enable-analytics-prompt` entry was dropped entirely, so that migration stopped shipping after 22.6.1. ## Expected Behavior The gitignore migration runs its real implementation (version left at 22.6.0-rc.0), and the analytics-prompt migration is wired again at its original 22.6.0-beta.11. `assertValidMigrationPaths` now fails when a migration entry-point file (a top-level `.ts` with a default export under a version dir) is referenced by no `migrations.json` entry, so a stranded or leftover migration file is caught in CI. That reverse check surfaced `update-17-3-0/nx-release-path`, an unwired migration dead since 2023, which is removed. ## Related Issue(s) Fixes NXC-4670 <!-- polygraph-session-start --> --- [View session information ↗](https://app.trypolygraph.com/orgs/6a061dcb561c062131116eca/sessions/fix-migrate-misc-issues-cfee7d13) <!-- polygraph-session-end --> (cherry picked from commit 99fc3b0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
A merge conflict during the move to the
./dist/...build layout left two Nx core migrations miswired. The22-6-0-add-claude-settings-local-to-git-ignoremigration pointed atupdate-17-3-0/update-nxw, so from 22.6.2 / 22.7.0-beta.2 onward, workspaces migrating across 22.6.0-rc.0 ran the nx-wrapper update instead of adding.claude/settings.local.jsonto.gitignore. The22-6-0-enable-analytics-promptentry was dropped entirely, so that migration stopped shipping after 22.6.1.Expected Behavior
The gitignore migration runs its real implementation (version left at 22.6.0-rc.0), and the analytics-prompt migration is wired again at its original 22.6.0-beta.11.
assertValidMigrationPathsnow fails when a migration entry-point file (a top-level.tswith a default export under a version dir) is referenced by nomigrations.jsonentry, so a stranded or leftover migration file is caught in CI. That reverse check surfacedupdate-17-3-0/nx-release-path, an unwired migration dead since 2023, which is removed.Related Issue(s)
Fixes NXC-4670
View session information ↗