Isaacs/do not force include so much stuff - #61
Merged
Conversation
isaacs
force-pushed
the
isaacs/do-not-force-include-so-much-stuff
branch
from
May 5, 2021 17:24
e765132 to
32983b9
Compare
nlf
approved these changes
May 5, 2021
isaacs
force-pushed
the
isaacs/do-not-force-include-so-much-stuff
branch
from
May 5, 2021 19:11
32983b9 to
2b29fc2
Compare
1 task
Closed
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-server
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-fs
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-logger
that referenced
this pull request
Jan 28, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-fs
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-server
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-logger
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
matz3
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 31, 2022
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
This was referenced May 12, 2025
owlstronaut
pushed a commit
to npm/cli
that referenced
this pull request
May 15, 2025
It seems that the `CHANGELOG` files are not in the never ignored list since npm/npm-packlist#61 ## References Also see the list at [package.json#files](https://docs.npmjs.com/cli/v11/configuring-npm/package-json#files).
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
… file The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
The CLI needs the changelog files of all modules to create a consolidated changelog. Since npm v7 the CHANGELOG file is not always published anymore. See: npm/npm-packlist#61
2 tasks
jdx
added a commit
to jdx/aube
that referenced
this pull request
Apr 23, 2026
## Summary - Remove `CHANGELOG*` from `pack`'s always-on file list, matching npm's behavior in [npm/npm-packlist#61](npm/npm-packlist#61). README and LICENSE/LICENCE still force-include. - Users who actually want a changelog shipped can list it in the `files` field. Closes [#226](#226). ## Test plan - [x] \`cargo build -p aube\` passes - [x] no existing bats/Rust tests reference \`CHANGELOG\` in pack/publish paths 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: narrows `aube pack`'s default always-included set by removing `CHANGELOG*`, which only affects tarball contents and not execution paths beyond packaging. > > **Overview** > Updates `aube pack` to **stop force-including `CHANGELOG*`** in generated tarballs, matching npm behavior; `README*` and `LICENSE*`/`LICENCE*` remain always included. > > Adds inline documentation explaining the exclusion and that users can still ship changelogs by listing them in `package.json` `files`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 06b73e6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References