Skip to content

Fix sdk pruning - #3706

Closed
georgevdd wants to merge 7 commits into
nodemcu:releasefrom
georgevdd:fix-sdk-pruning
Closed

Fix sdk pruning#3706
georgevdd wants to merge 7 commits into
nodemcu:releasefrom
georgevdd:fix-sdk-pruning

Conversation

@georgevdd

Copy link
Copy Markdown

Fixes #3705.

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

The main Makefile adjusts PATH to be able to find the toolchain's executables, but commands that require those executables must be executed in subshells otherwise they will not see the updated value of PATH.

@georgevdd georgevdd closed this May 30, 2026
@georgevdd

Copy link
Copy Markdown
Author

Accidentally made a PR for the release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK pruning rule uses the wrong ar

4 participants