Skip to content

fix(websocket): make WebSocket kRef/kUnref non-enumerable - #5795

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/make-ref-unref-non-enum
Open

fix(websocket): make WebSocket kRef/kUnref non-enumerable#5795
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/make-ref-unref-non-enum

Conversation

@jasnell

@jasnell jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@jasnell
jasnell requested a review from mcollina September 9, 2026 20:01

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnell force-pushed the jasnell/make-ref-unref-non-enum branch from 10e6eb7 to 4a2d693 Compare September 9, 2026 20:13
@jasnell

jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Test added

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (8d985d2) to head (4a2d693).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5795   +/-   ##
=======================================
  Coverage   93.50%   93.51%           
=======================================
  Files         110      110           
  Lines       39365    39373    +8     
=======================================
+ Hits        36810    36818    +8     
  Misses       2555     2555           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants