Skip to content

test(wpt): use the wpt submodule's test certificates - #5739

Open
kjsik11 wants to merge 1 commit into
nodejs:mainfrom
kjsik11:fix/wpt-expired-certs
Open

test(wpt): use the wpt submodule's test certificates#5739
kjsik11 wants to merge 1 commit into
nodejs:mainfrom
kjsik11:fix/wpt-expired-certs

Conversation

@kjsik11

@kjsik11 kjsik11 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

This relates to...

Rationale

WPT test cert file expired now so all local WPT test fails in https, wss cases

$ git show main:test/web-platform-tests/runner/certs/web-platform.test.pem | openssl x509 -noout -enddate -checkend 0
notAfter=Aug 29 20:32:30 2026 GMT
Certificate will expire

Changes

  • runner/config.jsonssl.pregenerated paths → tools/certs/*
  • wpt-runner.mjs — update CA_CERT_PATH, path to valid cert files
  • remove expired cert files on runner/certs/

Features

Bug Fixes

  • remove expired cert files + change path to valid cert files

Breaking Changes and Deprecations

Verification

$ node test/web-platform-tests/wpt-runner.mjs run /fetch/metadata/fetch.https.sub.any.html

0 passing / 6 failing on main; 18 passing / 12 failing with this pr

Full suite (/fetch /mimesniff /websockets /serviceWorkers /eventsource, 1040 files), Node.js 24:

passing failing
CI on #5732, 7h before expiry (log) 4810 4031
CI on #5740, 23h after expiry (log) 4649 4147
with this change 4810 4031

Last row ran in local cli(Node 24.20.0)

assisted by claude code

Status

@kjsik11 kjsik11 changed the title test(wpt): use the wpt submodule's test certificates test(wpt): use the wpt submodule's test certificates Aug 30, 2026
@mcollina
mcollina requested a review from KhafraDev August 31, 2026 10:26
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.45%. Comparing base (fc3450d) to head (fdc35ed).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5739      +/-   ##
==========================================
- Coverage   93.47%   93.45%   -0.02%     
==========================================
  Files         110      110              
  Lines       38908    38908              
==========================================
- Hits        36368    36362       -6     
- Misses       2540     2546       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants