fix: add missing error classes to types - #3316
Merged
Merged
Conversation
maxbeatty
force-pushed
the
add-missing-errors-types
branch
from
June 7, 2024 15:56
be41ebf to
64c7dd1
Compare
maxbeatty
marked this pull request as ready for review
June 7, 2024 15:57
mcollina
requested changes
Jun 8, 2024
maxbeatty
commented
Jun 9, 2024
metcoder95
reviewed
Jun 10, 2024
metcoder95
left a comment
metcoder95
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, just a small comment left 👍
metcoder95
changed the title
mcollina
reviewed
Jun 11, 2024
metcoder95
approved these changes
Jun 12, 2024
This was referenced Jul 8, 2024
This was referenced Jul 24, 2024
This was referenced Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
RequestRetryErrorandSecureProxyConnectionErrorare exported but not included in the typesRequestRetryErrorinconsistently setdataChanges
Exports new types for existing Error classes. When trying to type the classes, I saw that
datawas set inconsistently so matched the class implementation.Features
N/A
Bug Fixes
RequestRetryErrornow consistently setsdataBreaking Changes and Deprecations
N/A
Status