Skip to content

fix: fix retry handler option - #2962

Merged
ronag merged 2 commits into
nodejs:mainfrom
acommodari:fix-retry-handler-option
Mar 16, 2024
Merged

fix: fix retry handler option#2962
ronag merged 2 commits into
nodejs:mainfrom
acommodari:fix-retry-handler-option

Conversation

@acommodari

Copy link
Copy Markdown
Contributor

This relates to...

#2961

Rationale

To fix the issue #2961

Changes

  • add use strict to retry-handler.js
  • change timeout option in retry-handler.js to minTimeout to match docs and types.

Features

N/A

Bug Fixes

  • fix docs/types mismatch

Breaking Changes and Deprecations

Status

@ronag ronag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test?

@acommodari

Copy link
Copy Markdown
Contributor Author

can we have a test?

sure! in this case what would you like the test to cover? Would this be a test for types?

@Uzlopak

Uzlopak commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

write a test where the minTimeout is set

@codecov-commenter

codecov-commenter commented Mar 15, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (dcab693) to head (a921d47).
⚠️ Report is 1165 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2962   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          89       89           
  Lines       24171    24172    +1     
=======================================
+ Hits        22597    22598    +1     
  Misses       1574     1574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acommodari
acommodari force-pushed the fix-retry-handler-option branch from c982041 to a921d47 Compare March 15, 2024 18:55
@acommodari
acommodari requested a review from ronag March 15, 2024 18:56
@ronag
ronag merged commit 9a56796 into nodejs:main Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet