Skip to content

ci: add macos-latest to test-matrix - #2952

Merged
ronag merged 1 commit into
nodejs:mainfrom
Uzlopak:ci-add-macos
Mar 13, 2024
Merged

ci: add macos-latest to test-matrix#2952
ronag merged 1 commit into
nodejs:mainfrom
Uzlopak:ci-add-macos

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

CITGM is having macos-latet, but we dont.

nodejs/citgm#1051 (comment)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (94598c2) to head (f53fb90).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
- Coverage   93.68%   93.67%   -0.01%     
==========================================
  Files          87       87              
  Lines       23973    23999      +26     
==========================================
+ Hits        22458    22482      +24     
- Misses       1515     1517       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronag

ronag commented Mar 13, 2024

Copy link
Copy Markdown
Member

Need to fix failures.

@ronag

ronag commented Mar 13, 2024

Copy link
Copy Markdown
Member

Which OSX version is latest? I'm on 14.2 and can't reprop.

@targos

targos commented Mar 13, 2024

Copy link
Copy Markdown
Member

@Uzlopak

Uzlopak commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
ronag merged commit 3577ade into nodejs:main Mar 13, 2024
@Uzlopak
Uzlopak deleted the ci-add-macos branch March 14, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet