Skip to content

fix: move CNAME and .nojekyll to root - #2822

Merged
Ethan-Arrowood merged 1 commit into
nodejs:mainfrom
Uzlopak:move-files
Feb 23, 2024
Merged

fix: move CNAME and .nojekyll to root#2822
Ethan-Arrowood merged 1 commit into
nodejs:mainfrom
Uzlopak:move-files

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

currently the website is broken. the workflow to deploy is using jekyll for some reason. Maybe .nojekyll must be in root?
Also moving CNAME to root.

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't realize the docs move got merged. Yes - we also have to change repo settings

@Uzlopak

Uzlopak commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

Should we merge and in the hope it fixes the page?

@Ethan-Arrowood
Ethan-Arrowood merged commit 85a2402 into nodejs:main Feb 23, 2024
@Ethan-Arrowood

Copy link
Copy Markdown
Collaborator

yeah - I'm at my computer now and I can fix this

@Uzlopak
Uzlopak deleted the move-files branch February 23, 2024 00:58
@Uzlopak

Uzlopak commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

@Ethan-Arrowood
Should I stay up to approve potential PRs?

@Uzlopak

Uzlopak commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

YAY. Its up and running

@Ethan-Arrowood

Copy link
Copy Markdown
Collaborator

Nah I just pushed to main for this. Want to keep disruption to minimum. All should be restored now

@Uzlopak

Uzlopak commented Feb 23, 2024

Copy link
Copy Markdown
Contributor Author

docs/docs is looking funny :D

but yeah, better having the website running. do you want to take care of renaming it documentation, or is this something we have to live with?

Anyhow. I go to sleep now ;)

@Ethan-Arrowood

Copy link
Copy Markdown
Collaborator

Problem for another day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet