Skip to content

Update node-meetups.md - #2005

Merged
ZYSzys merged 10 commits into
nodejs:masterfrom
SofiEstevez:patch-1
Feb 6, 2019
Merged

Update node-meetups.md#2005
ZYSzys merged 10 commits into
nodejs:masterfrom
SofiEstevez:patch-1

Conversation

@SofiEstevez

Copy link
Copy Markdown
Contributor

Added a lot of meetups around the world :)

Comment thread locale/en/get-involved/node-meetups.md Outdated
ZYSzys and others added 2 commits January 24, 2019 17:19
Thanks for reviewing, will update :)

Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>

@ZYSzys ZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

@ZYSzys ZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the format should be:

### Country(like United States)

#### State(like California)

##### City(like San Francisco)

See: https://github.com/nodejs/nodejs.org/pull/1992/files#diff-f20affdaee1114975a78c88cafabd0adR30

- If you do not currently have a CoC, update the meetup with CoC before submitting.
- Submit your PR in alphabetical order.

## Meetups

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder why this line was deleted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought maybe it was obvious but no worries, will add again!

@ghost

ghost commented Feb 3, 2019

Copy link
Copy Markdown

@SofiEstevez:Maybe you can solve the conflicting files and push a submit, and we'll merge them.

@SofiEstevez

SofiEstevez commented Feb 4, 2019

Copy link
Copy Markdown
Contributor Author

@Maledong Thank you, I just resolved conflicts :)

@SofiEstevez

Copy link
Copy Markdown
Contributor Author

@ZYSzys are we good to merge?

@ZYSzys ZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll merge this once suggestions below landed.(if my suggestions below are not wrong) :)

Comment thread locale/en/get-involved/node-meetups.md Outdated
Comment thread locale/en/get-involved/node-meetups.md Outdated
SofiEstevez and others added 3 commits February 5, 2019 12:04
Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>
Sure, thank you for helping me formatting this!

Co-Authored-By: SofiEstevez <30813859+SofiEstevez@users.noreply.github.com>
@ZYSzys

ZYSzys commented Feb 5, 2019

Copy link
Copy Markdown
Member

Hi @SofiEstevez , I'm a bit of curoious why you delete some Organizer contact info 🤔?

@SofiEstevez

Copy link
Copy Markdown
Contributor Author

@ZYSzys oh sorry, I just realized I prefer to don't assume these people want to share their info.

@ZYSzys
ZYSzys merged commit 2fd6d1a into nodejs:master Feb 6, 2019
@ZYSzys

ZYSzys commented Feb 6, 2019

Copy link
Copy Markdown
Member

Thank you !👍

@ZYSzys ZYSzys mentioned this pull request Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants