-
-
Notifications
You must be signed in to change notification settings - Fork 36.6k
test: move tick-processor tests to own directory #9506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,12 @@ | |
| const common = require('../common'); | ||
|
|
||
| // TODO(mhdawson) Currently the test-tick-processor functionality in V8 | ||
| // depends on addresses being smaller than a full 64 bits. Aix supports | ||
| // depends on addresses being smaller than a full 64 bits. AIX supports | ||
| // the full 64 bits and the result is that it does not process the | ||
| // addresses correctly and runs out of memory | ||
| // Disabling until we get a fix upstreamed into V8 | ||
| if (common.isAix) { | ||
| common.skip('Aix address range too big for scripts.'); | ||
| common.skip('AIX address range too big for scripts.'); | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -21,7 +21,7 @@ const base = require('./tick-processor-base.js'); | |
| // Unknown checked for to prevent flakiness, if pattern is not found, | ||
| // then a large number of unknown ticks should be present | ||
| base.runTest({ | ||
| pattern: /LazyCompile.*\[eval\]:1|.*% UNKNOWN/, | ||
| pattern: /LazyCompile.*\[eval]:1|.*% UNKNOWN/, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this removed?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I personally find the explicit escaping more readable but I don't feel too strongly about it. |
||
| code: `function f() { | ||
| for (var i = 0; i < 1000000; i++) { | ||
| i++; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import sys, os | ||
| sys.path.append(os.path.join(os.path.dirname(__file__), '..')) | ||
| import testpy | ||
|
|
||
| def GetConfiguration(context, root): | ||
| return testpy.SimpleTestConfiguration(context, root, 'tick-processor') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably say
tick processorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! You are, of course, correct. Fixed. Thanks!