Skip to content

WIP: test-stdio-closed troubleshooting #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

WIP: test-stdio-closed troubleshooting #8414

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fae5c5f
wip
Trott Sep 6, 2016
847a642
squash: accept other than EBADF
Trott Sep 6, 2016
30ce6a4
squash: this will not fix it but eh...
Trott Sep 6, 2016
a1156d1
squash: put it back
Trott Sep 6, 2016
ed1019b
squash: confirm stdout is blowing up
Trott Sep 6, 2016
6b89af0
squash: typo fix
Trott Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4114,10 +4114,11 @@ inline void PlatformInit() {
continue;
// Anything but EBADF means something is seriously wrong. We don't
// have to special-case EINTR, fstat() is not interruptible.
// if (errno != EBADF)
// ABORT();
if (fd != open("/dev/null", O_RDWR))
if (errno != EBADF)
ABORT();
open("/dev/null", O_RDWR);

@veshboo veshboo Sep 6, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make sure that this open return current loop fd (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO).

@Trott Trott Sep 6, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Yes, no doubt. This is not intended to be merged. That's what the WIP (work in progress) and the in progress label are meant to indicate. Trying some non-intuitive (and quite possibly ignorant) things to try to figure out why this bit of code seems to be not working (or perhaps the associated test is what is not working) on AIX but working on all the other POSIX systems we test on.

@veshboo veshboo Sep 6, 2016 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this related to "AIX: parallel/test-stdio-closed #8375".

On AIX, I remember that there is a kernel parameter regarding max number of pseudo terminals allowed in the system. I suspect the issue is somehow related to the kernel parameter. Need to check the "errno" when the test fails.

EDIT: seems not directly related to pty because the path to open is "/dev/null".

// if (fd != open("/dev/null", O_RDWR))
// ABORT();
}

CHECK_EQ(err, 0);
Expand Down