Skip to content

fs,path: key glob matcher cache by platform - #64571

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Archkon:path
Jul 30, 2026
Merged

fs,path: key glob matcher cache by platform#64571
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Archkon:path

Conversation

@Archkon

@Archkon Archkon commented Jul 18, 2026

Copy link
Copy Markdown

Fixes: #64570

@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/path

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 18, 2026
@codecov

codecov Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (4a5eb1c) to head (f688be4).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #64571   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         744      744           
  Lines      242517   242518    +1     
  Branches    45688    45688           
=======================================
+ Hits       218642   218650    +8     
- Misses      15358    15361    +3     
+ Partials     8517     8507   -10
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.27% <100.00%> (+<0.01%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon

This comment was marked as spam.

Sign in to view
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74943/

@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@mag123c mag123c mentioned this pull request Jul 26, 2026
Open
@avivkeller

avivkeller commented Jul 26, 2026

Copy link
Copy Markdown
Member 
02:04:39 CONFLICT (add/add): Merge conflict in Makefile
02:04:39 error: could not apply 61890720c8a... add readme and initial code
02:04:39 hint: Resolve all conflicts manually, mark them as resolved with
02:04:40 hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
02:04:40 hint: You can instead skip this commit: run "git rebase --skip".
02:04:40 hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
02:04:40 Could not apply 61890720c8a... add readme and initial code
02:04:40 Build step 'Execute shell' marked build as failure

@Archkon please rebase, looks like CI needs you to

@Archkon
fs: key glob matcher cache by platform
f688be4 
Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75174/

@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75278/

@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 111a62d into nodejs:main Jul 30, 2026
74 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in 111a62d

aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@aduh95
fs: key glob matcher cache by platform
6efb84f 
Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64571
Fixes: #64570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@aduh95
fs: key glob matcher cache by platform
9209bf1 
Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64571
Fixes: #64570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
@aduh95
fs: key glob matcher cache by platform
b250b40 
Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64571
Fixes: #64570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@aduh95
fs: key glob matcher cache by platform
12f7fc0 
Glob matchers capture the path platform when they are created. Include
the platform in the cache key so path.posix and path.win32 do not share
incompatible matchers for the same pattern.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64571
Fixes: #64570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@MoLow MoLow MoLow approved these changes
@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

path: matchesGlob() cache does not distinguish path platforms

6 participants

@Archkon @nodejs-github-bot @avivkeller @jasnell @MoLow @lpinca