lib: coerce -0 to +0 in various APIs#63556
Open
panva wants to merge 5 commits into
Open
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
panva
changed the title
nodejs-github-bot
added
lib / src
aduh95
reviewed
May 25, 2026
Comment on lines
178
to
+180
| validateUint32(interval, 'interval'); | ||
| // Coerce -0 to +0. | ||
| interval += 0; |
Contributor
There was a problem hiding this comment.
Shouldn't we update validateUint32 to reject -0 instead?
Member
Author
There was a problem hiding this comment.
I have no particular sympathy for either or.
Contributor
There was a problem hiding this comment.
Having it part of the helper is probably more robust than relying on humans to remember for checking for -0
Contributor
There was a problem hiding this comment.
Having it part of the helper is probably more robust than relying on humans to remember for checking for
-0
Maybe even have it part of all uint conversion helpers?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63556 +/- ##
==========================================
+ Coverage 90.31% 90.34% +0.02%
==========================================
Files 730 730
Lines 234161 234414 +253
Branches 43917 43930 +13
==========================================
+ Hits 211486 211784 +298
+ Misses 14408 14376 -32
+ Partials 8267 8254 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #63531
This is not an exhaustive list of these occurences, just the ones I can remotely imagine being exposed to an untrusted used input through a web-based or CLI interface.
The tests demonstrate the process crashing before the
./libchanges.I used Codex to find and confirm these before diving in.