quic: add proper error codes & messages for QUIC failures#63198
Open
pimterry wants to merge 3 commits into
Open
quic: add proper error codes & messages for QUIC failures#63198pimterry wants to merge 3 commits into
pimterry wants to merge 3 commits into
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Tim Perry <pimterry@gmail.com>
31b4709 to
aefee4f
Compare
jasnell
reviewed
May 8, 2026
jasnell
reviewed
May 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63198 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.01%
==========================================
Files 713 713
Lines 224926 224983 +57
Branches 42525 42531 +6
==========================================
+ Hits 202526 202572 +46
- Misses 14180 14187 +7
- Partials 8220 8224 +4
🚀 New features to boost your workflow:
|
Signed-off-by: Tim Perry <pimterry@gmail.com>
Signed-off-by: Tim Perry <pimterry@gmail.com>
bjohansebas
reviewed
May 11, 2026
| E('ERR_PERFORMANCE_MEASURE_INVALID_OPTIONS', '%s', TypeError); | ||
| E('ERR_PROXY_INVALID_CONFIG', '%s', Error); | ||
| E('ERR_PROXY_TUNNEL', '%s', Error); | ||
| E('ERR_QUIC_APPLICATION_ERROR', 'A QUIC application error occurred. %d [%s]', Error); |
Member
Author
There was a problem hiding this comment.
This line is declaring an error class for that code, but with the last change here (40eebfd) from the review above, we no longer use the class itself - QUIC errors now always use QuicError instances, with the code set explicitly instead. Changes the constructor of the resulting error, but not the error.code value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps QUIC errors, providing useful error codes and messages for the defined error code cases from both OpenSSL and ngtcp2.
Before this, QUIC errors looked like:
Now they look like: