Skip to content

[v24.x backport] crypto,doc: selected crypto changes#63173

Open
panva wants to merge 4 commits intonodejs:v24.x-stagingfrom
panva:crypto-backports
Open

[v24.x backport] crypto,doc: selected crypto changes#63173
panva wants to merge 4 commits intonodejs:v24.x-stagingfrom
panva:crypto-backports

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented May 7, 2026 •
edited by aduh95
Loading

panva added 4 commits May 7, 2026 16:32
@panva
crypto: remove Argon2 KDF derivation from its job setup
0ffdb5e 
Fixes: nodejs#62861

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62863
Fixes: nodejs#62861
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@panva
crypto: reject unintended raw key format string input
2435326 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62974
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@panva
doc: fix typos and inconsistencies in crypto.md and webcrypto.md
684e9ca 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62828
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva
crypto: deduplicate and canonicalize CryptoKey usages
b0fb43c 
Fixes: nodejs#62899

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62902
Fixes: nodejs#62899
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 7, 2026

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 7, 2026
@panva panva changed the title crypto: remove Argon2 KDF derivation from its job setup [v24.x backport] several crypto backports May 7, 2026
@panva panva changed the title [v24.x backport] several crypto backports [v24.x backport] crypto,doc: selected crypto changes May 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 7, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73233/

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (c989497) to head (b0fb43c).
⚠️ Report is 478 commits behind head on v24.x-staging.

Additional details and impacted files 
@@               Coverage Diff                @@
##           v24.x-staging   #63173     +/-   ##
================================================
  Coverage          90.06%   90.07%             
================================================
  Files                672      675      +3     
  Lines             201174   203769   +2595     
  Branches           39304    39912    +608     
================================================
+ Hits              181197   183541   +2344     
- Misses             12240    12423    +183     
- Partials            7737     7805     +68
Files with missing lines Coverage Δ
lib/internal/crypto/aes.js 88.42% <100.00%> (-0.04%) ⬇️
lib/internal/crypto/cfrg.js 96.26% <100.00%> (+<0.01%) ⬆️
lib/internal/crypto/chacha20_poly1305.js 92.72% <100.00%> (-1.06%) ⬇️
lib/internal/crypto/ec.js 96.21% <100.00%> (ø)
lib/internal/crypto/keys.js 95.55% <100.00%> (+0.08%) ⬆️
lib/internal/crypto/mac.js 91.09% <100.00%> (-0.04%) ⬇️
lib/internal/crypto/ml_dsa.js 95.18% <100.00%> (+1.47%) ⬆️
lib/internal/crypto/ml_kem.js 92.13% <100.00%> (+1.75%) ⬆️
lib/internal/crypto/rsa.js 94.10% <100.00%> (ø)
lib/internal/crypto/util.js 95.61% <100.00%> (+0.11%) ⬆️
... and 2 more

... and 186 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 7, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73245/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@panva @nodejs-github-bot