Skip to content

doc: add LJHarb to collaborators#56132

Merged
ljharb merged 1 commit into
nodejs:mainfrom
ljharb:ljharb-collab
Dec 4, 2024
Merged

doc: add LJHarb to collaborators#56132
ljharb merged 1 commit into
nodejs:mainfrom
ljharb:ljharb-collab

Conversation

@ljharb
Copy link
Copy Markdown
Member

@ljharb ljharb commented Dec 4, 2024

Fixes: #55918

@ljharb ljharb added the doc Issues and PRs related to the documentations. label Dec 4, 2024
@ljharb ljharb requested review from anonrig and removed request for anonrig December 4, 2024 19:15
@ljharb ljharb added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 72 hours to land. labels Dec 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2024

Fast-track has been requested by @ljharb. Please 👍 to approve.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @ljharb.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@ljharb ljharb mentioned this pull request Dec 4, 2024
Closed
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2024
debadree25
debadree25 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!!

@ljharb
doc: add LJHarb to collaborators
c4aa34a 
Fixes: nodejs#55918
PR-URL: nodejs#56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@ljharb ljharb merged commit c4aa34a into nodejs:main Dec 4, 2024
@ljharb ljharb deleted the ljharb-collab branch December 4, 2024 19:37
@ljharb
Copy link
Copy Markdown
Member Author

ljharb commented Dec 4, 2024

Landed c4aa34a.

@targos targos mentioned this pull request Dec 6, 2024
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@ronag ronag ronag approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@debadree25 debadree25 debadree25 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. notable-change PRs with changes that should be highlighted in changelogs.

Milestone

No milestone