test: fix http-response-multiheaders - #3958
Conversation
Make sure the server is not closed until both responses have been received.
|
It tries to fix #2815. The same |
r-52
added
http
|
LGTM I'm seeing problems with this test on Windows too. https://ci.nodejs.org/job/node-test-binary-windows/384/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/console So I'm kind of motivated to get this fix in now. Stress test without the fix proposed here: https://ci.nodejs.org/job/node-stress-single-test/196/nodes=win2012r2/console Stress test with the fix proposed here: https://ci.nodejs.org/job/node-stress-single-test/197/nodes=win2012r2/console |
|
LGTM |
|
Stress test looks good. LGTM. |
Make sure the server is not closed until both responses have been received. PR-URL: #3958 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in 025e4aa. Thanks once again for all these test fixes you've been working on! |
Make sure the server is not closed until both responses have been received. PR-URL: nodejs#3958 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
It looks like this makes changes to a test that was added in a semver major. @rvagg I am currently removing the lts-watch tag and adding the do-not-land tag Please feel free to update this |
Make sure the server is not closed until both responses have been received. PR-URL: nodejs#3958 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
6 participants
Make sure the server is not closed until both responses have been
received.