Skip to content

build: remove --code-cache-path help option #28446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

build: remove --code-cache-path help option #28446

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db4857
build: remove --code-cache-path help option
danbev Jun 27, 2019
5dfb434
build: rename node_code_cache_path to node_code_cache
danbev Jul 2, 2019
f57b8a6
squash:! add comment
danbev Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,11 +515,6 @@
dest='without_siphash',
help=optparse.SUPPRESS_HELP)

parser.add_option('--code-cache-path',
action='store',
dest='code_cache_path',
help='optparse.SUPPRESS_HELP')

# End dummy list.

parser.add_option('--without-ssl',
Expand Down Expand Up @@ -1116,7 +1111,7 @@ def configure_node(o):
o['variables']['node_no_browser_globals'] = b(options.no_browser_globals)
# TODO(refack): fix this when implementing embedded code-cache when cross-compiling.
if o['variables']['want_separate_host_toolset'] == 0:
o['variables']['node_code_cache_path'] = 'yes'
o['variables']['node_code_cache'] = 'yes'
Comment thread
danbev marked this conversation as resolved.
Outdated
o['variables']['node_shared'] = b(options.shared)
node_module_version = getmoduleversion.get_version()

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-code-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (!process.features.cached_builtins) {
}
} else { // Native compiled
assert.strictEqual(
process.config.variables.node_code_cache_path,
process.config.variables.node_code_cache,
'yes'
);

Expand Down