test: simplify tests code - #28065
Closed
himself65 wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
test
ZYSzys
reviewed
Jun 5, 2019
cjihrig
approved these changes
Jun 5, 2019
Collaborator
ZYSzys
approved these changes
Jun 5, 2019
ZYSzys
added
the
author ready
BridgeAR
approved these changes
Jun 5, 2019
richardlau
reviewed
Jun 5, 2019
richardlau
approved these changes
Jun 6, 2019
trivikr
approved these changes
Jun 6, 2019
Trott
approved these changes
Jun 9, 2019
Collaborator
Member
|
Landed in fefc275 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Jun 9, 2019
PR-URL: #28065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28065 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes