Skip to content

test: fix test-worker-memory.js for large cpu #s #27090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 2 commits into from
Closed

test: fix test-worker-memory.js for large cpu #s #27090

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3f93e
test: fix test-worker-memory.js for large cpu #s
mhdawson Apr 4, 2019
9902b1c
Squash: address comment
richardlau Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/parallel/test-worker-memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ const assert = require('assert');
const util = require('util');
const { Worker } = require('worker_threads');

const numWorkers = +process.env.JOBS || require('os').cpus().length;
let numWorkers = +process.env.JOBS || require('os').cpus().length;
if (numWorkers > 20) {
// Cap the number of workers at 20 (as an even divsor of 60 used as
Comment thread
mhdawson marked this conversation as resolved.
Outdated
// the total number of workers started) otherwise the test fails on
// machines with high core counts.
numWorkers = 20;
}

// Verify that a Worker's memory isn't kept in memory after the thread finishes.

Expand Down